Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e test and include them in pipeline #140

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Improve e2e test and include them in pipeline #140

merged 1 commit into from
Oct 31, 2023

Conversation

emilwareus
Copy link
Contributor

No description provided.

@emilwareus emilwareus self-assigned this Oct 30, 2023
@emilwareus emilwareus marked this pull request as draft October 30, 2023 19:11
emilwareus
emilwareus commented Oct 31, 2023
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
test/resolve/resolver_test.go Show resolved Hide resolved
test/resolve/testdata/pip/requirements.txt Outdated Show resolved Hide resolved
@emilwareus emilwareus requested a review from sweoggy October 31, 2023 07:32
@emilwareus emilwareus marked this pull request as ready for review October 31, 2023 07:32
sweoggy
sweoggy approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@sweoggy sweoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and quick E2E tests!

@emilwareus
add e2e tests to resolve and docker in ci pipelines.
fcec992 
Additionally, fix some bugs in images with missing dependencies to resolve python manifests
@github-actions
Copy link

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 0 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

@sweoggy sweoggy merged commit a0a7184 into main Oct 31, 2023
25 checks passed
@sweoggy sweoggy deleted the improve-e2e-tests branch October 31, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweoggy sweoggy sweoggy approved these changes

Assignees

@emilwareus emilwareus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilwareus @sweoggy