Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of .debricked-call-graph to debricked-call-graph #138

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

ProgHaj
Copy link
Collaborator

@ProgHaj ProgHaj commented Oct 25, 2023

No description provided.

@ProgHaj ProgHaj marked this pull request as ready for review October 25, 2023 14:28
@github-actions
Copy link

CodeScene PR Check


View detailed results in CodeScene

Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 0 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

Copy link
Contributor

@emilwareus emilwareus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sweoggy sweoggy merged commit bfc0966 into vuln-func-cmd Oct 26, 2023
14 checks passed
@sweoggy sweoggy deleted the 0-vuln-func-update-output-naming branch October 26, 2023 12:47
@sweoggy
Copy link
Member

sweoggy commented Oct 26, 2023

Backend support added about an hour ago, I will go ahead and merge this now :)

sweoggy pushed a commit that referenced this pull request Oct 30, 2023
* Add vf-cli for java (mvn) to cli

* Refactor find-files and finder logic

* Add callgraph cmd test

* Refactor MapFilesToDir

* Improve test coverage

* Rewrite tests to be OS-agnostic

* Add build flag to call graph command, without build functionality.

* Add viper binding for build flag and fix test not asserting flags as intended.

* Change build arg to no-build arg to indicate that auto build is default.

* Add build arg to callgraph config and strategy.

* Add build maven package cmd and call it if auto build is enabled (default true).

* Add functionality to run maven package compilation (build) step by default with a flag to disable it.

* Add mini java project for testing and test build on it.

* add functional test to make sure build works correctly. this test is slow and should possibly be separated in the future.

* Fix linting issues, including a cyclic complexity reduction (at a cost).

* Ignore the build target location in case it was not properly deleted in a failed test run.

* Add spinner UI in CLI for the build step of Maven projects in call graph. Add rich error logging.

* Improve testing of error logging.

* Add a Command struct that wraps os/exec.Cmd to allow mocking for test purposes.

* Implement command mock. Refactor command methods to allow better testing.

* Add upload + postprocess logic to java callgraph and improve tests

* Improve testing in io, command and callgraph

* Cleanup

* Move mvn test to correct folder

* Remove gradle callgraph logic from groovy file

* Fix windows problem

* Fix an issue where the zipping tool was looking in root instead of the real location of the call graph.

* Fix mapping pom files to class directories

* Increase time before timeout to 60min

* Change build to only fail if all build pom.xml fails

* Increase upload time for callgraphs to 10min

* Add fix for zipped filename being a long location

* Rewrite java-callgraph-files logic to handle each .class-dir + .jar-files

* Update sootWrapper to support .jar-files

* Change to refresh files of interest after build

* Add functionality to stop run preemptively if error occours

* Add --generate-timeout flag to callgraph command

* Add callgraph generation timeout and upload timeout flags to scan command

* Add e2e test of callgraph generation

* Move exclude logic to its own module

* Move callgraph finder from io to callgraph package

* Utilise Excluded in callgraph finder

* Add test coverage for callgraph finder file exclusion

* Update callgraph documentation

* Fix failing tests

* Change deps of pom.xml file

* Update SootWrapper

* Change name of .debricked-call-graph to debricked-call-graph (#138)

* Change to scan for groups after callgraph generated

* Update documentation link

* Add windows-latest to e2e tests again

* Fix general cleanup

---------

Co-authored-by: AntonDebricked <[email protected]>
Co-authored-by: filip-debricked <[email protected]>
Co-authored-by: jonnadebricked <[email protected]>
Co-authored-by: klaradebricked <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants