Fixes lint errors

debricked · Aug 26, 2024 · e0f797c · e0f797c
1 parent 0dfbe6c
commit e0f797c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 18 deletions.
diff --git a/internal/callgraph/language/java11/strategy.go b/internal/callgraph/language/java11/strategy.go
@@ -110,7 +110,7 @@ func NewStrategy(config conf.IConfig, paths []string, exclusions []string, inclu
 }
 
 func strategyWarning(errMsg string) {
-	err := fmt.Errorf(errMsg)
+	err := fmt.Errorf("%s", errMsg)
 	warningColor := color.New(color.FgYellow, color.Bold).SprintFunc()
 	defaultOutputWriter := log.Writer()
 	log.Println(warningColor("Warning: ") + err.Error())

diff --git a/internal/file/finder.go b/internal/file/finder.go
@@ -93,12 +93,6 @@ func isCompressed(filename string) bool {
 	return compressed
 }
 
-func (finder *Finder) getWorkspaces(options DebrickedOptions) ([]string, error) {
-	var workspaces []string
-
-	return workspaces, nil
-}
-
 func (finder *Finder) GetIncludedGroups(formats []*CompiledFormat, options DebrickedOptions) (Groups, error) {
 	// NOTE: inefficient because it walks into excluded directories
 	var groups Groups

diff --git a/internal/file/groups.go b/internal/file/groups.go
@@ -116,7 +116,7 @@ func (gs *Groups) GetFiles() []string {
 	return files
 }
 
-func (gs *Groups) matchWorkspace(workspaceManifest WorkspaceManifest) error {
+func (gs *Groups) matchWorkspace(workspaceManifest WorkspaceManifest) {
 	for _, g := range gs.groups {
 		// If group g is missing lockfile and does not have the same manifest
 		if len(g.LockFiles) == 0 && g.ManifestFile != workspaceManifest.RootManifest {
@@ -126,10 +126,9 @@ func (gs *Groups) matchWorkspace(workspaceManifest WorkspaceManifest) error {
 			}
 		}
 	}
-	return nil
 }
 
-func (gs *Groups) AddWorkspaceLockFiles() error {
+func (gs *Groups) AddWorkspaceLockFiles() {
 	for _, group := range gs.groups {
 		workspaces, err := getWorkspaces(group.ManifestFile)
 		if err == nil && group.HasLockFiles() {
@@ -139,9 +138,6 @@ func (gs *Groups) AddWorkspaceLockFiles() error {
 				Workspaces:   workspaces,
 			}
 			gs.matchWorkspace(workspaceManifest)
-
 		}
 	}
-	return nil
-
 }
diff --git a/internal/file/groups_test.go b/internal/file/groups_test.go
@@ -202,8 +202,7 @@ func TestGroupsMatchWorkspaces(t *testing.T) {
 		RootManifest: "package.json",
 		Workspaces:   []string{"package/*"},
 	}
-	err := gs.matchWorkspace(workspaceManifest)
-	assert.NoError(t, err)
+	gs.matchWorkspace(workspaceManifest)
 	for _, g := range gs.groups {
 		if g.ManifestFile == "package/file3" {
 			assert.Equal(t, g.LockFiles[0], g1.LockFiles[0])
@@ -224,8 +223,7 @@ func TestAddWorkspaceLockFiles(t *testing.T) {
 	gs.Add(*g1)
 	gs.Add(*g2)
 	gs.Add(*g3)
-	err := gs.AddWorkspaceLockFiles()
-	assert.NoError(t, err)
+	gs.AddWorkspaceLockFiles()
 	for _, g := range gs.groups {
 		assert.Equal(t, len(g.LockFiles), 1)
 		if len(g.LockFiles) == 1 {

diff --git a/internal/fingerprint/fingerprint_test.go b/internal/fingerprint/fingerprint_test.go
@@ -15,7 +15,7 @@ var errorString = "mock error"
 
 // Test errors in symlink
 func mockSymlink(filename string) (bool, error) {
-	return false, fmt.Errorf(errorString)
+	return false, fmt.Errorf("%s", errorString)
 }
 func TestShouldProcessFile(t *testing.T) {
 	// Create a temporary directory to use for testing