Escape & for windows cmd

debricked · Sep 17, 2024 · b2a8cef · b2a8cef
1 parent 52370c0
commit b2a8cef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/auth/callback.go b/internal/auth/callback.go
@@ -65,6 +65,7 @@ func (awh AuthWebHelper) openBrowserCmd(runtimeOS, url string) *exec.Cmd {
 	switch runtimeOS {
 	case "windows":
 		cmd = "cmd"
+		url = "\"" + url + "\"" // Windows does not like "&"
 		args = []string{"/c", "start"}
 	case "darwin":
 		cmd = "open"

diff --git a/internal/auth/callback_test.go b/internal/auth/callback_test.go
@@ -110,7 +110,7 @@ func TestOpenBrowserCmd(t *testing.T) {
 		},
 		{
 			runtimeOS:   "windows",
-			expectedCmd: exec.Command("cmd", "/c", "start", "url"),
+			expectedCmd: exec.Command("cmd", "/c", "start", "\"url\""),
 		},
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -110,7 +110,7 @@ func TestOpenBrowserCmd(t *testing.T) { @@
     		},
     		{
     			runtimeOS:   "windows",
-    			expectedCmd: exec.Command("cmd", "/c", "start", "url"),
+    			expectedCmd: exec.Command("cmd", "/c", "start", "\"url\""),
     		},
     	}
@@ Expand Down @@