Skip to content

Commit

Permalink
Fix failing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ProgHaj committed Oct 20, 2023
1 parent 04a9c4c commit 13a712b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion internal/callgraph/scheduler.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func (scheduler *Scheduler) Schedule(jobs []job.IJob, ctx cgexec.IContext) (IGen
scheduler.spinnerManager.Start()

for _, j := range jobs {
spinner := scheduler.spinnerManager.AddSpinner(callgraph, j.GetDir())
spinner := scheduler.spinnerManager.AddSpinner(j.GetDir())
scheduler.queue <- queueItem{
job: j,
spinner: spinner,
Expand Down
4 changes: 2 additions & 2 deletions internal/cmd/root/root_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
func TestNewRootCmd(t *testing.T) {
cmd := NewRootCmd("v0.0.0", wire.GetCliContainer())
commands := cmd.Commands()
nbrOfCommands := 5
nbrOfCommands := 6
if len(commands) != nbrOfCommands {
t.Errorf("failed to assert that there were %d sub commands connected", nbrOfCommands)
}
Expand All @@ -31,7 +31,7 @@ func TestNewRootCmd(t *testing.T) {
}
}
assert.Truef(t, match, "failed to assert that flag was present: "+AccessTokenFlag)
assert.Len(t, viperKeys, 13)
assert.Len(t, viperKeys, 14)
}

func TestPreRun(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions internal/file/exclusion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func TestExclude(t *testing.T) {
{
name: "FileExclusionWithDoublestar",
exclusions: []string{"**/composer.json"},
expectedExclusions: []string{"composer.json"},
expectedExclusions: []string{"composer.json", "composer.json"}, // Two composer.json files in testdata folder
},
{
name: "DirectoryExclusion",
Expand All @@ -129,7 +129,7 @@ func TestExclude(t *testing.T) {
{
name: "ExtensionExclusionWithWildcardAndDoublestar",
exclusions: []string{"**/*.mod"},
expectedExclusions: []string{"go.mod"},
expectedExclusions: []string{"go.mod", "go.mod"}, // Two go.mod files in testdata folder
},
{
name: "DirectoryExclusionWithDoublestar",
Expand Down
2 changes: 0 additions & 2 deletions internal/resolution/scheduler.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ type Scheduler struct {
spinnerManager tui.ISpinnerManager
}

const resolving = "Resolving"

func NewScheduler(workers int) *Scheduler {
return &Scheduler{workers: workers, waitGroup: sync.WaitGroup{}}
}
Expand Down
2 changes: 0 additions & 2 deletions internal/tui/spinner_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import (
"github.com/stretchr/testify/assert"
)

const resolving = "Resolving"

func TestNewSpinnerManager(t *testing.T) {
spinnerManager := NewSpinnerManager(
"Resolving",
Expand Down

0 comments on commit 13a712b

Please sign in to comment.