Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Mutation Methods #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

f3lan
Copy link

@f3lan f3lan commented Nov 15, 2019

Hi @ddrscott,

I saw that the PR #2 was incomplete. So I took the chance to finish the work of @biozid-0208.

What I did:

  1. I merged the newest master and the feature branch into a new branch.
  2. I cleaned up the spec/anonymizer/mutator_spec.rb file, to be in consistence with the the list of all methods.
  3. I fixed the specs.
  4. I updated the README.me and added the new methods to the list.

I hope, you can use this MR, otherwise let me know how I can help you.

Best Regards,

@f3lan

@ddrscott
Copy link
Owner

Sorry for the late response, I'll get on this tomorrow to rebase, double check, and merger.

@f3lan
Copy link
Author

f3lan commented Nov 22, 2019

Hi @ddrscott,

no worries. If you need help or if I can clarify something, let me know.

Best regards,

@f3lan

@f3lan
Copy link
Author

f3lan commented Nov 28, 2019

Hi @ddrscott,

I fixed the merge request for this MR. 😄.

Best regards,

@f3lan

@ddrscott
Copy link
Owner

Can you reset to ddrscott:master and git cherry-pick cf267f6d8db1cd216cf15b40e355e4bf7d737b2d?
That'll make it so I can merge using GH.

BTW. Thanks for all of this! I'm glad someone still getting use out of the project.

@f3lan
Copy link
Author

f3lan commented Nov 28, 2019

Hi @ddrscott,

Unfortunately I do not understand you here. It is for me a bit problematic to cherry-pick a merge commit. If you want I can rebase and deselect commits you may not want in the master.

We are happy to use this gem for anonymise our test databases. Thanks for the great work!

Best regards,

@f3lan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants