[Metadata] Persist metadata changes on the DB (#190)

* [Metadata] Save metadata after modification * [Metadata] Add tests for deleting and restoring a trashed card
dchege711 · Jul 5, 2024 · afe5d2a · afe5d2a
1 parent 19088d7
commit afe5d2a
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 7 deletions.
diff --git a/src/models/MetadataMongoDB.ts b/src/models/MetadataMongoDB.ts
@@ -182,7 +182,7 @@ export async function updatePublicUserMetadata(
 
   metadataDoc.markModified("stats");
   metadataDoc.markModified("node_information");
-  // await metadataDoc.save();
+  await metadataDoc.save();
 
   return metadataDoc;
 }
@@ -262,7 +262,7 @@ export async function sendCardToTrash(
   metadataDoc.markModified("node_information");
   metadataDoc.markModified("trashed_cards");
 
-  // await metadataDoc.save();
+  await metadataDoc.save();
 
   return `Card moved to the trash. <span class="underline_bold_text clickable" onclick="restoreCardFromTrash('${card._id}', '${card.urgency}')">Undo Action</span>`;
 }
@@ -294,7 +294,7 @@ export async function restoreCardFromTrash(
     card.tags,
     "urgency",
   );
-  // await metadataDoc.save();
+  await metadataDoc.save();
 
   return `${card.title} has been restored!`;
 }
@@ -320,7 +320,7 @@ export async function deleteCardFromTrash(
   }
 
   const metadataDoc = await removeCardFromMetadataTrash(card);
-  // await metadataDoc.save();
+  await metadataDoc.save();
 
   return `${card.title} has been permanently deleted!`;
 }
@@ -350,7 +350,7 @@ async function removeCardFromMetadataTrash(
   if (cardIdentifier._id in metadataDoc.trashed_cards[0]) {
     delete metadataDoc.trashed_cards[0][cardIdentifier._id];
     metadataDoc.markModified("trashed_cards");
-    // await metadataDoc.save();
+    await metadataDoc.save();
     return metadataDoc;
   } else {
     return Promise.reject("Card wasn't found in the trash");
@@ -510,7 +510,7 @@ export async function updateUserSettings(
     }
     metadataDoc.streak.dailyTarget = newUserSettings.dailyTarget;
     metadataDoc.markModified("streak");
-    // await metadataDoc.save();
+    await metadataDoc.save();
   }
 
   return user.save();

diff --git a/src/routes/InAppRouter.test.ts b/src/routes/InAppRouter.test.ts
@@ -249,10 +249,13 @@ describe("/trpc/updateCard", function() {
 });
 
 describe("/trpc/trashCard", function() {
+  let cardID: string;
+
   this.beforeEach(async () => {
     const gUser = await authenticateUser(authDetails);
     gCaller = createCaller({ user: gUser });
-    return await createPublicAndPrivateCards(gUser);
+    ({ samplePublicCardId: cardID } = await createPublicAndPrivateCards(gUser));
+    return Promise.resolve();
   });
 
   it("should use an input parser/validator", function(done) {
@@ -264,6 +267,43 @@ describe("/trpc/trashCard", function() {
       passIfValidationError(e, done);
     });
   });
+
+  describe("when a card is trashed", function() {
+    this.beforeEach(async () => {
+      {
+        const trashedCards = (await gCaller.metadata())[0].trashed_cards;
+        expect(trashedCards.length).equal(0);
+      }
+
+      await gCaller.trashCard({ _id: cardID });
+
+      {
+        const trashedCards = (await gCaller.metadata())[0].trashed_cards;
+        expect(trashedCards.length).equal(1);
+        expect(Object.keys(trashedCards[0])).contains(cardID);
+      }
+    });
+
+    it("should delete the card via /trpc/deleteCard", async () => {
+      await gCaller.deleteCard({ _id: cardID });
+
+      const trashedCards = (await gCaller.metadata())[0].trashed_cards;
+      expect(trashedCards).deep.equal([{}]);
+
+      const card = await gCaller.fetchCard({ cardID: cardID });
+      expect(card).to.be.null;
+    });
+
+    it("should restore the card via /trpc/restoreCardFromTrash", async () => {
+      await gCaller.restoreCardFromTrash({ _id: cardID });
+
+      const trashedCards = (await gCaller.metadata())[0].trashed_cards;
+      expect(trashedCards).deep.equal([{}]);
+
+      const card = await gCaller.fetchCard({ cardID: cardID });
+      expect(card?._id.toString()).to.equal(cardID);
+    });
+  });
 });
 
 describe("/trpc/deleteCard", function() {