feat: add support for groupby-only adhoc queries #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for group_by only adhoc queries with no metrics. This has a similar effect to listing dimension values, and is being added to the SDK for parity with what the ADBC and GraphQL APIs can do already. I changed the validation logic to allow for it, and I added test cases for it.
This commit adds typing to the groupby only queries.
serramatutu
force-pushed
the
serramatutu/query-groupby
branch
from
978e480 to
1e1e1a0
Compare
|
PS: I didn't add it to this PR since it was kind of out of scope, so I merged it without that and I'm opening this as a followup. |
WilliamDee
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adhoc queries with only
group_by, without ametric. This is equivalent to doingclient.dimension_values("my_dimension"), but since the raw APIs support it, I thought it would be nice to keep parity here as well.I changed the validation logic to allow this, and I added unit and integration test cases to cover it. I also changed the
.pyifiles so that users get LSP suggestions for this use case.You can review by commit.