feat: saved queries in query and compile_sql
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `saved_query` to `query` and `compile_sql`, so it's now possible to use them with saved queries. I added some method overrides so that typecheckers can detect invalid usage of them, and I also created a method which validates at runtime whether the parameters are valid before submitting them to the servers.
WilliamDee
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds saved queries to
queryandcompile_sql. I used@overloadso that users have the option to statically typecheck for correct usage of the args, i.e that they're not usingmetricsandgroup_bywithsaved_query. I also added a client-side validation for query parameters before we submit queries to the servers.