Skip to content

Commit

Permalink
Add order_by and limit to v12 manifest (#65)
Browse files Browse the repository at this point in the history 
Originally this work was done as part of #49.
However as they are additive fields that have a default values, they aren't
breaking changes. Thus here we're adding them to the v12 manifest. This is
in support of the currently open dbt-core PR dbt-labs/dbt-core#10532.

Note this also _drops_ the `vars` field from a few objects. It was originally added
to support changes in core (dbt-labs/dbt-core#10793). However,
those changes were reverted in core (dbt-labs/dbt-core#10813).
Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us
to drop it.
  • Loading branch information
@QMalcolm
QMalcolm authored Oct 15, 2024
1 parent 2ffa615 commit b5ff4af
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 122 deletions.
178 changes: 57 additions & 121 deletions dbt/manifest/v12.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"dbt_version": {
"type": "string",
"default": "1.9.0a1"
"default": "1.9.0b2"
},
"generated_at": {
"type": "string"
Expand Down Expand Up @@ -727,12 +727,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"root_path": {
"anyOf": [
{
Expand Down Expand Up @@ -1772,12 +1766,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -2432,12 +2420,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -3229,12 +3211,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -4045,12 +4021,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -5412,12 +5382,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -6072,12 +6036,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -6769,6 +6727,17 @@
}
},
"additionalProperties": false
},
"dbt_valid_to_current": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"default": null
}
},
"additionalProperties": true
Expand Down Expand Up @@ -7036,12 +7005,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -8179,12 +8142,6 @@
"type": "string"
}
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"relation_name": {
"anyOf": [
{
Expand Down Expand Up @@ -8578,12 +8535,6 @@
"type": "string"
}
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"url": {
"anyOf": [
{
Expand Down Expand Up @@ -10661,12 +10612,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"root_path": {
"anyOf": [
{
Expand Down Expand Up @@ -11706,12 +11651,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -12366,12 +12305,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -13163,12 +13096,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -13979,12 +13906,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -15346,12 +15267,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -16006,12 +15921,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -16703,6 +16612,17 @@
}
},
"additionalProperties": false
},
"dbt_valid_to_current": {
"anyOf": [
{
"type": "string"
},
{
"type": "null"
}
],
"default": null
}
},
"additionalProperties": true
Expand Down Expand Up @@ -16970,12 +16890,6 @@
"type": "string",
"default": ""
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"language": {
"type": "string",
"default": "sql"
Expand Down Expand Up @@ -18104,12 +18018,6 @@
"type": "string"
}
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"relation_name": {
"anyOf": [
{
Expand Down Expand Up @@ -18301,12 +18209,6 @@
"type": "string"
}
},
"vars": {
"type": "object",
"propertyNames": {
"type": "string"
}
},
"url": {
"anyOf": [
{
Expand Down Expand Up @@ -19736,6 +19638,23 @@
"type": "null"
}
]
},
"order_by": {
"type": "array",
"items": {
"type": "string"
}
},
"limit": {
"anyOf": [
{
"type": "integer"
},
{
"type": "null"
}
],
"default": null
}
},
"additionalProperties": false,
Expand Down Expand Up @@ -21270,6 +21189,23 @@
"type": "null"
}
]
},
"order_by": {
"type": "array",
"items": {
"type": "string"
}
},
"limit": {
"anyOf": [
{
"type": "integer"
},
{
"type": "null"
}
],
"default": null
}
},
"additionalProperties": false,
Expand Down
2 changes: 1 addition & 1 deletion dbt/manifest/v12/index.html
View file

Large diffs are not rendered by default.

0 comments on commit b5ff4af

Please sign in to comment.