Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile updates #844

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Makefile updates #844

merged 1 commit into from
Nov 6, 2023

Conversation

courtneyholcomb
Copy link
Contributor

Description

Makefile updates:

  • Removes quotes from variables. The commands work without the quotes. Sometimes they work with the quotes, but there are some cases where the quotes cause errors.
  • Adds test-snap target, something I use often to see snapshot changes without waiting for all SQL engines to run.

@cla-bot cla-bot bot added the cla:yes label Nov 3, 2023
@courtneyholcomb courtneyholcomb requested review from tlento, WilliamDee and plypaul and removed request for tlento and WilliamDee November 4, 2023 00:04
tlento
tlento approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astronaut dog

@courtneyholcomb courtneyholcomb merged commit fbf744a into main Nov 6, 2023
34 checks passed
@courtneyholcomb courtneyholcomb deleted the court/makefile branch November 6, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlento tlento tlento approved these changes

@plypaul plypaul Awaiting requested review from plypaul

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@courtneyholcomb @tlento