Update minimum typing-extensions version to 4.4 #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
force-pushed
the
fix-typing-extensions-min-version
branch
from
a2a8a81 to
ad3a966
Compare
The @OverRide decorator was added to typing-extensions with version 4.4, but our minimum version is 4.0, which means there are scenarios where this will suddenly start throwing errors. Since we require 4.4, let's make that true in the build directive.
tlento
force-pushed
the
fix-typing-extensions-min-version
branch
from
ad3a966 to
be143f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@overridedecorator was added to typing-extensions with version4.4, but our minimum version is 4.0, which means there are scenarios
where this will suddenly start throwing errors.
Since we require 4.4, let's make that true in the build directive.