Remove error for date part with non-metric time dimension #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
approved these changes
Oct 17, 2023
courtneyholcomb
added a commit
that referenced
this pull request
Oct 17, 2023
courtneyholcomb
added a commit
that referenced
this pull request
Oct 17, 2023
sarbmeetka
pushed a commit
to sarbmeetka/metricflow
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found a bug where date part queries error for any time dimension that isn't
metric_time. This wasn't caught because all of our tests usedmetric_time(in both MF and MFS) - lesson learned! This creates an instant bug if you try to use any time dimension besidesmetric_timein our Tableau integration.This is not the ideal fix. Ideally we'll need to put
date_partin the validation path the way thattime_granularityis, but we don't have time to do that before the fix needs to ship.