Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trino support to MetricFlow #810

Closed
wants to merge 18 commits into from
Closed

Add trino support to MetricFlow #810

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e0e95c1
Add trino adapter support for MetricFlow
sarbmeetka Oct 5, 2023
cfd11c3
lint
sarbmeetka Oct 5, 2023
e857500
Handle timestamp literals for range operator
sarbmeetka Oct 8, 2023
16feb86
Update test cases to handle group by for Trino in metrics calculation
sarbmeetka Oct 8, 2023
72e9112
Handle dry run and approx percentile for Trino along with more explic…
sarbmeetka Oct 9, 2023
bf83458
Add changelog
sarbmeetka Oct 9, 2023
73b71da
Fix percentile function and rename sqltimedelta function in Trino client
sarbmeetka Oct 24, 2023
1738d09
Handle extract for Trino
sarbmeetka Nov 14, 2023
69bb34b
fix lint issues
sarbmeetka Nov 14, 2023
b54e03b
Fix additional test case snapshots related to extract function
sarbmeetka Nov 14, 2023
949f3d1
Use positional arguments in group by to fix tests
sarbmeetka Nov 14, 2023
bfd1414
Fix time delta expression for Trino and regenerate snapshot
sarbmeetka Nov 14, 2023
00dc026
Add trino to cd-sql-engine-tests
sarbmeetka Nov 15, 2023
f4df9fa
Address function inline comments
sarbmeetka Nov 22, 2023
c9d7229
bump version for dependencies
sarbmeetka Nov 22, 2023
6034199
Fix test cases for trino related to ts scalar expression
sarbmeetka Dec 16, 2023
c009a84
change grouping to positional param for order limit test
sarbmeetka Dec 16, 2023
4c9021a
Fix pending test case
sarbmeetka Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions metricflow/test/integration/query_output/test_cumulative_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,19 @@ def test_cumulative_metric_with_non_adjustable_filter(
it_helpers: IntegrationTestHelpers,
) -> None:
"""Tests a cumulative metric with a filter that cannot be adjusted to ensure all data is included."""

# Handle ds expression based on engine to support Trino.
first_ds_expr = f"CAST('2020-03-15' AS {sql_client.sql_query_plan_renderer.expr_renderer.timestamp_data_type})"
second_ds_expr = f"CAST('2020-04-30' AS {sql_client.sql_query_plan_renderer.expr_renderer.timestamp_data_type})"
where_constraint = f"{{{{ TimeDimension('metric_time', 'day') }}}} = {first_ds_expr} or"
where_constraint += f" {{{{ TimeDimension('metric_time', 'day') }}}} = {second_ds_expr}"
Comment on lines +138 to +141
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. Ok, Trino makes this interface issue worse, but addressing this is way outside the scope of this PR. I'll open an internal issue for us to consider here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but this was blocking test to succeed successfully. Wasn't sure on getting around this.


query_result = it_helpers.mf_engine.query(
MetricFlowQueryRequest.create_with_random_request_id(
metric_names=["trailing_2_months_revenue"],
group_by_names=["metric_time"],
order_by_names=["metric_time"],
where_constraint=(
"{{ TimeDimension('metric_time', 'day') }} = '2020-03-15' or "
"{{ TimeDimension('metric_time', 'day') }} = '2020-04-30'"
),
where_constraint=where_constraint,
time_constraint_end=as_datetime("2020-12-31"),
)
)
Expand Down
Loading