Validate Semantic Manifests Used in Tests #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
plypaul
force-pushed
the
plypaul--56--validate-test-manifests
branch
from
19f7bfb to
d9e2114
Compare
plypaul
changed the base branch from
main
to
plypaul--53--populate-persistent-source-schema-gha
plypaul
force-pushed
the
plypaul--56--validate-test-manifests
branch
from
d9e2114 to
d474347
Compare
plypaul
added
the
Reload Test Data in SQL Engines
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Reload Test Data in SQL Engines
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
force-pushed
the
plypaul--53--populate-persistent-source-schema-gha
branch
3 times, most recently
from
3f88ff4 to
609c080
Compare
Base automatically changed from
plypaul--53--populate-persistent-source-schema-gha
to
main
September 19, 2023 19:52
plypaul
force-pushed
the
plypaul--56--validate-test-manifests
branch
2 times, most recently
from
5d93fae to
05a0996
Compare
This makes tests easier to fix after a changes to semantic models.
plypaul
force-pushed
the
plypaul--56--validate-test-manifests
branch
from
05a0996 to
8cf1790
Compare
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
QMalcolm
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When DSI was cut out from MF, it seems that the validation for the semantic manifests used tests was removed. This PR updates the test fixtures so that validations are run on those manifests and makes fixes as needed so that those validations pass.