Don't reduce verbose SQL expressions #1586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/custom-offset6
branch
from
bebe99d to
81ae325
Compare
courtneyholcomb
force-pushed
the
court/custom-offset6
branch
from
3740d81 to
ef1dbdc
Compare
courtneyholcomb
force-pushed
the
court/custom-offset6.5
branch
from
ac725b7 to
ff3d3f9
Compare
WilliamDee
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
any of these logics needs to be added to this file too? https://github.com/dbt-labs/metricflow/blob/main/metricflow/sql/optimizer/sub_query_reducer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the optimizer from reducing expressions that can be very hard to read when collapsed into a second expression. They are especially hard to read when they are repeated in multiple columns in the child expression.