Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker for DuckDb-only tests #1565

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Add marker for DuckDb-only tests #1565

merged 1 commit into from
Dec 12, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Dec 11, 2024

This PR adds a pytest marker that allows tests to only be run when testing using DuckDB. This is useful in integration test cases where engine-specific SQL rendering is not being tested. This can help to reduce test suite runtimes and to reduce the number of snapshots.

@cla-bot cla-bot bot added the cla:yes label Dec 11, 2024
@plypaul plypaul added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Dec 11, 2024
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS December 11, 2024 21:05 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS December 11, 2024 21:05 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS December 11, 2024 21:05 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS December 11, 2024 21:05 — with GitHub Actions Inactive
@plypaul plypaul marked this pull request as ready for review December 11, 2024 21:32
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Dec 11, 2024
Copy link
Contributor

@WilliamDee WilliamDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we put a backlog to go through the tests to add this marker whereever necessary as a clean up?

@plypaul
Copy link
Contributor Author

plypaul commented Dec 12, 2024

Yeah, that would be ideal, but it would be a lot to go through all the tests. I figure we start by updating as we go at first.

@plypaul plypaul merged commit 91d444a into main Dec 12, 2024
53 checks passed
@plypaul plypaul deleted the p--misc--01 branch December 12, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants