Skip to content

Commit

Permalink
Update integration test to require entity name
Browse files Browse the repository at this point in the history
  • Loading branch information
@courtneyholcomb
courtneyholcomb committed Oct 11, 2023
1 parent c9526e5 commit f84d0b6
Show file tree
Hide file tree
Showing 49 changed files with 603 additions and 1,985 deletions.
1 change: 1 addition & 0 deletions ...est/snapshots/test_cm_branch_combiner.py/DataflowPlan/test_filter_combination__dfpo_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<!-- {'class': 'MeasureSpec', -->
<!-- 'element_name': 'booking_value', -->
<!-- 'non_additive_dimension_spec': None} -->
<!-- distinct = False -->
<ReadSqlSourceNode>
<!-- description = -->
<!-- Read From SemanticModelDataSet(SemanticModelReference(semantic_model_name='bookings_source')) -->
Expand Down
7 changes: 5 additions & 2 deletions metricflow/test/snapshots/test_cyclic_join.py/DataflowPlan/test_cyclic_join__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<!-- 'element_name': 'capacity_latest', -->
<!-- 'entity_links': ({'class': 'EntityReference', -->
<!-- 'element_name': 'cyclic_entity'},)} -->
<!-- distinct = False -->
<JoinToBaseOutputNode>
<!-- description = Join Standard Outputs -->
<!-- node_id = jso_0 -->
Expand All @@ -54,14 +55,15 @@
<!-- {'class': 'LinklessEntitySpec', -->
<!-- 'element_name': 'cyclic_entity', -->
<!-- 'entity_links': ()} -->
<!-- distinct = False -->
<MetricTimeDimensionTransformNode>
<!-- description = Metric Time Dimension 'ds' -->
<!-- node_id = sma_10010 -->
<!-- aggregation_time_dimension = ds -->
<ReadSqlSourceNode>
<!-- description = -->
<!-- Read From SemanticModelDataSet(SemanticModelReference(semantic_model_name='listings_latest')) -->
<!-- node_id = rss_10044 -->
<!-- node_id = rss_10046 -->
<!-- data_set = -->
<!-- SemanticModelDataSet(SemanticModelReference(semantic_model_name='listings_latest')) -->
</ReadSqlSourceNode>
Expand All @@ -80,10 +82,11 @@
<!-- {'class': 'LinklessEntitySpec', -->
<!-- 'element_name': 'cyclic_entity', -->
<!-- 'entity_links': ()} -->
<!-- distinct = False -->
<ReadSqlSourceNode>
<!-- description = -->
<!-- Read From SemanticModelDataSet(SemanticModelReference(semantic_model_name='listings_latest_cyclic')) -->
<!-- node_id = rss_10045 -->
<!-- node_id = rss_10047 -->
<!-- data_set = -->
<!-- SemanticModelDataSet(SemanticModelReference(semantic_model_name='listings_latest_cyclic')) -->
</ReadSqlSourceNode>
Expand Down
6 changes: 6 additions & 0 deletions ...napshots/test_dataflow_plan_builder.py/DataflowPlan/test_common_semantic_model__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<!-- {'class': 'DimensionSpec', -->
<!-- 'element_name': 'country_latest', -->
<!-- 'entity_links': ({'class': 'EntityReference', 'element_name': 'listing'},)} -->
<!-- distinct = False -->
<JoinToBaseOutputNode>
<!-- description = Join Standard Outputs -->
<!-- node_id = jso_0 -->
Expand Down Expand Up @@ -69,6 +70,7 @@
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- include_spec = LinklessEntitySpec(element_name='listing', entity_links=()) -->
<!-- distinct = False -->
<MetricTimeDimensionTransformNode>
<!-- description = Metric Time Dimension 'ds' -->
<!-- node_id = sma_10001 -->
Expand All @@ -90,6 +92,7 @@
<!-- include_spec = -->
<!-- {'class': 'DimensionSpec', 'element_name': 'country_latest', 'entity_links': ()} -->
<!-- include_spec = LinklessEntitySpec(element_name='listing', entity_links=()) -->
<!-- distinct = False -->
<MetricTimeDimensionTransformNode>
<!-- description = Metric Time Dimension 'ds' -->
<!-- node_id = sma_10004 -->
Expand Down Expand Up @@ -140,6 +143,7 @@
<!-- {'class': 'DimensionSpec', -->
<!-- 'element_name': 'country_latest', -->
<!-- 'entity_links': ({'class': 'EntityReference', 'element_name': 'listing'},)} -->
<!-- distinct = False -->
<JoinToBaseOutputNode>
<!-- description = Join Standard Outputs -->
<!-- node_id = jso_1 -->
Expand Down Expand Up @@ -169,6 +173,7 @@
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- include_spec = LinklessEntitySpec(element_name='listing', entity_links=()) -->
<!-- distinct = False -->
<MetricTimeDimensionTransformNode>
<!-- description = Metric Time Dimension 'ds' -->
<!-- node_id = sma_10001 -->
Expand All @@ -190,6 +195,7 @@
<!-- include_spec = -->
<!-- {'class': 'DimensionSpec', 'element_name': 'country_latest', 'entity_links': ()} -->
<!-- include_spec = LinklessEntitySpec(element_name='listing', entity_links=()) -->
<!-- distinct = False -->
<MetricTimeDimensionTransformNode>
<!-- description = Metric Time Dimension 'ds' -->
<!-- node_id = sma_10004 -->
Expand Down
1 change: 1 addition & 0 deletions ...der.py/DataflowPlan/test_cumulative_metric_no_window_or_grain_with_metric_time__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<!-- 'time_granularity': TimeGranularity.QUARTER, -->
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- distinct = False -->
<JoinOverTimeRangeNode>
<!-- description = Join Self Over Time Range -->
<!-- node_id = jotr_0 -->
Expand Down
1 change: 1 addition & 0 deletions ....py/DataflowPlan/test_cumulative_metric_no_window_or_grain_without_metric_time__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
<!-- {'class': 'MeasureSpec', -->
<!-- 'element_name': 'txn_revenue', -->
<!-- 'non_additive_dimension_spec': None} -->
<!-- distinct = False -->
<MetricTimeDimensionTransformNode>
<!-- description = Metric Time Dimension 'ds' -->
<!-- node_id = sma_10005 -->
Expand Down
1 change: 1 addition & 0 deletions .../test_dataflow_plan_builder.py/DataflowPlan/test_cumulative_metric_with_window__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<!-- 'time_granularity': TimeGranularity.MONTH, -->
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- distinct = False -->
<JoinOverTimeRangeNode>
<!-- description = Join Self Over Time Range -->
<!-- node_id = jotr_0 -->
Expand Down
2 changes: 2 additions & 0 deletions ...test_dataflow_plan_builder.py/DataflowPlan/test_derived_metric_offset_to_grain__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<!-- 'time_granularity': TimeGranularity.DAY, -->
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- distinct = False -->
<MetricTimeDimensionTransformNode>
<!-- description = Metric Time Dimension 'ds' -->
<!-- node_id = sma_10001 -->
Expand Down Expand Up @@ -89,6 +90,7 @@
<!-- 'time_granularity': TimeGranularity.DAY, -->
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- distinct = False -->
<JoinToTimeSpineNode>
<!-- description = Join to Time Spine Dataset -->
<!-- node_id = jts_0 -->
Expand Down
1 change: 1 addition & 0 deletions ...s/test_dataflow_plan_builder.py/DataflowPlan/test_derived_metric_offset_window__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<!-- 'time_granularity': TimeGranularity.DAY, -->
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- distinct = False -->
<JoinToTimeSpineNode>
<!-- description = Join to Time Spine Dataset -->
<!-- node_id = jts_0 -->
Expand Down
1 change: 1 addition & 0 deletions ...aflow_plan_builder.py/DataflowPlan/test_derived_metric_offset_with_granularity__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<!-- 'time_granularity': TimeGranularity.MONTH, -->
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- distinct = False -->
<JoinToTimeSpineNode>
<!-- description = Join to Time Spine Dataset -->
<!-- node_id = jts_0 -->
Expand Down
1 change: 1 addition & 0 deletions ...st_dataflow_plan_builder.py/DataflowPlan/test_derived_offset_cumulative_metric__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<!-- 'time_granularity': TimeGranularity.DAY, -->
<!-- 'date_part': None, -->
<!-- 'aggregation_state': None} -->
<!-- distinct = False -->
<JoinToTimeSpineNode>
<!-- description = Join to Time Spine Dataset -->
<!-- node_id = jts_0 -->
Expand Down
Loading

0 comments on commit f84d0b6

Please sign in to comment.