Skip to content

Commit

Permalink
Remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Nov 2, 2023
1 parent 6e42eb2 commit a537af9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -925,8 +925,6 @@ def _build_aggregated_measures_from_measure_source_node(

# Only join to time spine if metric time was requested in the query.
if join_aggregated_measure_to_time_spine and metric_time_dimension_requested:
# TODO: if multiple measures in same node and only some join to time spine, should we split them into
# separate AggregateMeasuresNodes?
return JoinToTimeSpineNode(
parent_node=aggregate_measures_node,
requested_metric_time_dimension_specs=metric_time_dimension_specs,
Expand Down

0 comments on commit a537af9

Please sign in to comment.