Skip to content

Commit

Permalink
/* PR_START p--misc 04 */ Fix argument name in _create_data_sets.
Browse files Browse the repository at this point in the history
  • Loading branch information
plypaul committed Dec 11, 2024
1 parent c36f2db commit 905d0c0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests_metricflow/fixtures/manifest_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def _data_set_to_read_nodes(

@staticmethod
def _create_data_sets(
multihop_semantic_manifest_lookup: SemanticManifestLookup,
semantic_manifest_lookup: SemanticManifestLookup,
) -> OrderedDict[str, SemanticModelDataSet]:
"""Convert the SemanticModels in the model to SqlDataSets.
Expand All @@ -244,11 +244,11 @@ def _create_data_sets(

# Use ordered dict and sort by name to get consistency when running tests.
data_sets = OrderedDict()
semantic_models: Sequence[SemanticModel] = multihop_semantic_manifest_lookup.semantic_manifest.semantic_models
semantic_models: Sequence[SemanticModel] = semantic_manifest_lookup.semantic_manifest.semantic_models
semantic_models = sorted(semantic_models, key=lambda x: x.name)

converter = SemanticModelToDataSetConverter(
column_association_resolver=DunderColumnAssociationResolver(multihop_semantic_manifest_lookup)
column_association_resolver=DunderColumnAssociationResolver(semantic_manifest_lookup)
)

for semantic_model in semantic_models:
Expand Down

0 comments on commit 905d0c0

Please sign in to comment.