Skip to content

Commit

Permalink
Move TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Oct 31, 2023
1 parent 0c9d653 commit 5c3d51b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -923,9 +923,10 @@ def _build_aggregated_measures_from_measure_source_node(
join_aggregated_measure_to_time_spine = True
break

# TODO: if multiple measures and only some join to time spine, should we aggregate separately?
# Only join to time spine if metric time was requested in the query.
if join_aggregated_measure_to_time_spine and metric_time_dimension_requested:
# TODO: if multiple measures in same node and only some join to time spine, should we split them into
# separate AggregateMeasuresNodes?
return JoinToTimeSpineNode(
parent_node=aggregate_measures_node,
requested_metric_time_dimension_specs=metric_time_dimension_specs,
Expand Down

0 comments on commit 5c3d51b

Please sign in to comment.