Merge main

.changes/unreleased/Under the Hood-20230912-161509.yaml

@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: A simple update to make the where filter query parameter objects more accurate
+time: 2023-09-12T16:15:09.057779-05:00
+custom:
+  Author: DevonFulcher
+  Issue: None

metricflow/specs/where_filter_entity.py

@@ -26,14 +26,6 @@ def _implements_protocol(self) -> QueryInterfaceEntity:
     def __init__(self, column_name: str):  # noqa
         self.column_name = column_name
 
-    def grain(self, _grain: str) -> WhereFilterEntity:
-        """The time granularity."""
-        raise NotImplementedError
-
-    def alias(self, _alias: str) -> WhereFilterEntity:
-        """Renaming the column."""
-        raise NotImplementedError
-
     def __str__(self) -> str:
         """Returns the column name.
 

metricflow/specs/where_filter_time_dimension.py

@@ -10,32 +10,20 @@
 from typing_extensions import override
 
 from metricflow.specs.column_assoc import ColumnAssociationResolver
-from metricflow.specs.query_interface import QueryInterfaceDimension, QueryInterfaceTimeDimensionFactory
+from metricflow.specs.query_interface import QueryInterfaceTimeDimension, QueryInterfaceTimeDimensionFactory
 from metricflow.specs.specs import TimeDimensionSpec
 
 
-class WhereFilterTimeDimension(ProtocolHint[QueryInterfaceDimension]):
+class WhereFilterTimeDimension(ProtocolHint[QueryInterfaceTimeDimension]):
     """A time dimension that is passed in through the where filter parameter."""
 
     @override
-    def _implements_protocol(self) -> QueryInterfaceDimension:
+    def _implements_protocol(self) -> QueryInterfaceTimeDimension:
         return self
 
     def __init__(self, column_name: str):  # noqa
         self.column_name = column_name
 
-    def grain(self, _grain: str) -> WhereFilterTimeDimension:
-        """The time granularity."""
-        raise NotImplementedError
-
-    def date_part(self, _date_part: str) -> WhereFilterTimeDimension:
-        """Requested date_part to extract."""
-        raise NotImplementedError
-
-    def alias(self, _alias: str) -> WhereFilterTimeDimension:
-        """Renaming the column."""
-        raise NotImplementedError
-
     def __str__(self) -> str:
         """Returns the column name.