Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors occur on mf validate-configs #62

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix errors occur on mf validate-configs #62

wants to merge 3 commits into from

Conversation

Rindrics
Copy link

@Rindrics Rindrics commented Mar 4, 2024 •
edited
Loading

The problem occurred

What I did to resolve the problem

  • correct aggregation types of some measures to avoid to generate unsupported SUM() aggregation
  • add missed column landing_page_id to the seed table olist_closed_deals
  • execute mf validate-configs on CI

this PR closes #61

Rindrics added 2 commits March 4, 2024 07:28
@Rindrics
Aggregate using count_distinct to resolve error
1737829 
The error got in `mf validate-configs`:
> ✖ Breaking issues found when checking semantics of built manifest (ERRORS: 8, FUTURE_ERRORS: 0, WARNINGS: 0)
> • ERROR: with metric `mql_to_seller_conversion_rate_1_week_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_1_week_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window_with_filter`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window_with_filter`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_base`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_base`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
@Rindrics
Add column landing_page_id to seed data to resolve error
367cc4f 
> • ERROR: with semantic model `olist_closed_deals`  - Failed to query entities in data warehouse for semantic model `olist_closed_deals`
> Received following error from data warehouse:
> Runtime Error
>   Binder Error: Referenced column "landing_page_id" not found in FROM clause!
>   Candidate bindings: "olist_closed_deals_src_2.lead_type"
>   LINE 7:   , landing_page_id AS landing_page
>               ^
> • ERROR: with entity `landing_page` in semantic model `olist_closed_deals`  - Unable to query entity `landing_page` on semantic model `olist_closed_deals` in data warehouse
> Received following error from data warehouse:
> Runtime Error
>   Binder Error: Referenced column "landing_page_id" not found in FROM clause!
>   Candidate bindings: "olist_closed_deals_src_2.lead_type"
>   LINE 5:   landing_page_id AS landing_page
>             ^
@Rindrics Rindrics changed the title Fix errors occurs on mf validate-configs Fix errors occur on mf validate-configs Mar 4, 2024
@Rindrics Rindrics force-pushed the fix-error-on-mf-validate-config branch 2 times, most recently from 98967db to f1ddecc Compare March 4, 2024 08:08
@Rindrics Rindrics force-pushed the fix-error-on-mf-validate-config branch from f1ddecc to 9a10f5b Compare March 4, 2024 08:08
@Rindrics Rindrics marked this pull request as ready for review March 4, 2024 08:09
@Vitor-Avila Vitor-Avila mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mf validation to CI mf validate-configs fails
1 participant
@Rindrics