Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added global version callout #6710

Merged
merged 7 commits into from
Dec 23, 2024
Merged

Added global version callout #6710

merged 7 commits into from
Dec 23, 2024

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Dec 23, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

I have created this PR to add a global VersionCallout component that allows us to set a version callout for the snapshot_meta_column_names and Unit tests doc

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner December 23, 2024 14:35
@vercel Vercel
Copy link

vercel bot commented Dec 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 23, 2024 3:23pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 23, 2024
mirnawong1
mirnawong1 reviewed Dec 23, 2024
View reviewed changes
website/docs/docs/build/unit-tests.md Outdated
@@ -8,6 +8,8 @@ keywords:
- unit test, unit tests, unit testing, dag
---

<VersionCallout version="1.9" />

:::note

Unit testing functionality is available in [dbt Cloud Release Tracks](/docs/dbt-versions/cloud-release-tracks) or dbt Core v1.8+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nataliefiann should you remove the line 13 callout in lieu of the component?

mirnawong1
mirnawong1 reviewed Dec 23, 2024
View reviewed changes
website/docs/docs/build/unit-tests.md Outdated
@@ -8,6 +8,8 @@ keywords:
- unit test, unit tests, unit testing, dag
---

<VersionCallout version="1.9" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 1.8 instead since unit tests are available from 1.8 and higher?

@mirnawong1
Copy link
Contributor

lgtm!

@mirnawong1 mirnawong1 merged commit 538b687 into add-version-callout Dec 23, 2024
6 checks passed
@mirnawong1 mirnawong1 deleted the nat-add-version-callout branch December 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 left review comments

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataliefiann @mirnawong1