Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --favor-state note #6648

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Update --favor-state note #6648

merged 4 commits into from
Dec 16, 2024

Conversation

marcelobour
Copy link
Contributor

What are you changing in this pull request and why?

While it's clear that --favor-state skips step 1, mentioning only "production metadata" without addressing staging metadata could be misleading.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

While it's clear that --favor-state skips step 1, mentioning only "production metadata" without addressing staging metadata could be misleading.
@marcelobour marcelobour requested a review from a team as a code owner December 12, 2024 02:39
Copy link

welcome bot commented Dec 12, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 12, 2024 2:42am

Copy link

vercel bot commented Dec 12, 2024

@marcelobour is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Dec 12, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 12, 2024
@marcelobour marcelobour changed the title Update --favor-state Note Update --favor-state note Dec 12, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @marcelobour thanks so much for opening this pr for clarification! it looks great and made a small tweak. looks good to me and merging to me!

@mirnawong1 mirnawong1 merged commit 4d2ef6d into dbt-labs:current Dec 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants