[do not merge] saved queries support tags #6632
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
changed the title
github-actions
bot
added
size: large
| @@ -17,8 +17,32 @@ To create a saved query, refer to the following table parameters. | |||
| :::tip | |||
| Note that we use the double colon (::) to indicate whether a parameter is nested within another parameter. So for example, `query_params::metrics` means the `metrics` parameter is nested under `query_params`. | |||
| ::: | |||
|
|
|||
| <!-- For versions 1.9 and higher --> | |||
| <VersionBlock firstVersion="1.9"> | |||
There was a problem hiding this comment.
I didn't review this as I'm not sure what has changed and it doesn't seem related to tags
| models: | ||
| - name: model_name | ||
| config: | ||
| tags: <string> | [<string>] |
There was a problem hiding this comment.
this change is wrong, at least for saved queries. They support both string and [string] types for tags.
| config: | ||
| tags: | ||
| - order_metrics | ||
| - hourly |
There was a problem hiding this comment.
Putting the tags inside the config is not how I built this to work or expected it to work, but it DOES work, so that's pretty cool, and I think it's more in line with how other things work, so... thanks for making this better I guess! lol
| config: | ||
| tags: <string> | [<string>] | ||
| tags: string |
There was a problem hiding this comment.
I don't know about tags for sub-properties like columns, but since the term is plural, I'd be a little surprised if this change was correct. :/
| resource_type: | ||
| - name: resource_name | ||
| config: | ||
| tags: string |
There was a problem hiding this comment.
(see comment on the red side)
this pr adds a new feature where saved queries supports
tags.currently waiting for eng update on this as still working through
notion docs project
🚀 Deployment available! Here are the direct links to the updated files: