Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created new section called Parallel batch execution #6589
Created new section called Parallel batch execution #6589
Changes from 66 commits
9db07cc
2f5ec6e
ca9e4e9
8fd0faa
ca3e04c
0cb99ba
099a2bc
40c57e8
2491176
e9a42d7
efbeae5
ed3132e
3e207c0
cbed4d6
6d9e7c1
f349a16
a8e56df
7c89a59
c17a31a
5e24a5a
7ae1121
4da02b1
bc2adaf
b30107c
1460526
ed0fa04
dadbe4a
6a7af2c
3c9539b
9a4b3c0
4cfa151
f989037
28e11af
e4c9bf2
be2d332
7384dd9
979f689
690286f
dc700ab
5f41e4c
e54777a
08c4b5c
fd5351f
ab12f7b
32144f5
4b54892
8f38762
864f52d
e060242
504fb91
113b356
dfc6555
33f0166
97d96c0
ff16511
b06f3ea
7586373
c9c1012
d1f94cc
8504487
14ccc71
c7f6642
349f912
2227b72
f4b3b15
292aef4
722851f
7967a82
78d0dd6
37a8ba8
722778b
685cbd1
ed8b85b
19b4095
f102e15
d873999
7f824a4
261f781
6f84d2b
ef3ccc3
3926908
6c66d84
258a66d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @QMalcolm
I also wanted to ask about line 317. In the git issue, it advises:
"If neither (1) nor (2) was hit, then we check if a config concurrent_batches is set for the model. If the value for that config is True then we run the batches in parallel, if False we run the batches sequentially.
If however concurrent_batches is None (i.e. not set), then we check if the model jinja contains a reference to this. If it references this then we run the batches sequentially. Otherwise, we run them in parallel."
Whereas, from your notes, it advises:
"After [1], [2], and [3] we check if the this jinja function is invoked in the model. If this is used, then the batch will be run sequentially, as it may be that your batch depends on the existence of prior batches. If this isn't used, the batch will be run in parallel.
You can override the check for this by setting concurrent_batches to either True or False. If set to False, the batch will be run sequentially. If set to True the batch will be run in parallel (assuming [1], [2], and [3])..."
I just wanted to double check if they meant the same thing as I was a little confused.
Kind Regards
Natalie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! Happy to clarify ❤️ Also sorry for the confusion 😅
Those two things are saying the same thing. The first one walks through the actual logical order of operations that happens in core. The second is framed from how the end user should think about it. Basically, the user in ~98% of cases shouldn't think about or set
concurrent_batches
. Core does its best to automatically detect whether a batch can be run in parallel or not. The configconcurrent_batches
is an "escape hatch" to allow the user to say "I actually think these batches should/shouldn't be run in parallel".concurrent_batches
isn't a gate but instead an override.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nataliefiann checking w quigley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed