Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add microbatch updates #6351

Merged
merged 5 commits into from
Oct 29, 2024
Merged

add microbatch updates #6351

merged 5 commits into from
Oct 29, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Oct 24, 2024 •
edited
Loading

this pr adds updates to incremental microbatch per core prs:

  • #10878 - makes it so --event-time-start adn --event-time-end are mutually required.
  • #10876 - changes lookback default window to 1 (from 0)

[ X ] dbt Core PRs must get merged first before docs pr is merged

🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 24, 2024 09:27
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 29, 2024 10:25pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Oct 24, 2024
@mirnawong1 mirnawong1 changed the title add microbatch updates [do not merge yet] add microbatch updates Oct 24, 2024
@mirnawong1 mirnawong1 marked this pull request as draft October 24, 2024 09:30
@mirnawong1 mirnawong1 mentioned this pull request Oct 25, 2024
Closed
@mirnawong1 mirnawong1 marked this pull request as ready for review October 29, 2024 22:19
@mirnawong1 mirnawong1 changed the title [do not merge yet] add microbatch updates add microbatch updates Oct 29, 2024
@mirnawong1
Copy link
Contributor Author

Ok to merge and confirmed by Quigley: https://dbt-labs.slack.com/archives/C078A5CBAKH/p1730240522223969?thread_ts=1729541237.088979&channel=C078A5CBAKH&message_ts=1730240522.223969

runleonarun
runleonarun approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@runleonarun runleonarun merged commit b1f9c68 into current Oct 29, 2024
13 checks passed
@runleonarun runleonarun deleted the update-microbatch branch October 29, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirnawong1 @runleonarun