Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify current support level for contracts for materialized views #5993

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Clarify current support level for contracts for materialized views #5993

merged 1 commit into from
Aug 30, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Aug 29, 2024 •
edited
Loading

Preview

What are you changing in this pull request and why?

  • It isn't clear if materialized views have support for model contracts or not.
  • Also not clear if custom materializations automatically include support for model contracts or not.

Context: dbt-labs/dbt-snowflake#888 (dynamic table is the Snowflake equivalent of materialized view in other data platforms)

Checklist

@vercel Vercel
Copy link

vercel bot commented Aug 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 29, 2024 11:41pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Aug 29, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review August 29, 2024 23:40
@dbeatty10 dbeatty10 requested a review from a team as a code owner August 29, 2024 23:40
mirnawong1
mirnawong1 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks so much @dbeatty10

@mirnawong1 mirnawong1 merged commit d302701 into current Aug 30, 2024
14 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty10-patch-1 branch August 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1