Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt Core and DuckDB Quickstart #5783
base: current
Are you sure you want to change the base?
dbt Core and DuckDB Quickstart #5783
Changes from 202 commits
b5f877e
8e87af0
487683b
b93d5a7
1a263c0
737826a
4636a97
71a295a
ecc4644
198b9ed
596f913
2cbd39d
d510e86
433a233
95da0ef
bc67c43
a85abe7
4bed10f
aa47478
77a9a56
3595de9
67df5d1
d5a484d
3f84a70
9bb262a
ce37ba1
67b118d
cbc6d9f
014c807
35da071
3bef381
4fe47e0
16f30e9
5be2a99
8f41cd5
4a6229a
4f044b5
45570bc
13ab426
5e11419
01a44ba
6447c77
a7adfbc
c99ee45
6b7c7f3
d1a6688
50dadb3
838e0b2
9eedf93
4d880c5
7cf068b
695d074
c12c427
5da6811
1b290b1
52df759
5318fed
f66c476
8076fee
9a90e9f
6581ca4
a1a964d
6086855
9f05b09
77bc71d
ac1dfe9
d8b3160
2ff2a2b
c4f939c
10d6a20
854db28
eccb75b
5de815a
41e1912
54800e2
2362f8f
1aa255c
c2fea76
6b3f4dc
449e38c
f4e204b
2f7ec40
9d25f13
6997420
4d68595
7dabecf
4c1303a
7787011
ab914d5
4d886b4
f7db06a
2b30ec9
2458acc
00b70da
7990ade
eb33964
fdfec1d
28db5a4
727e442
1a1ae4b
c2c23f8
b1030c9
1233c91
4881a8c
59c81d5
438ff11
54df96f
8def9ac
ccabf79
0a38455
02cb68f
5019f26
078ff3a
180a391
3313417
7c8c13c
530073c
28937ab
0dc252d
72fef03
0c32afa
c040e8d
b94f3aa
c6e5be2
db47202
352ae56
9dca2bb
d0bb622
8b6a171
ba3a2a1
a279b70
faa2190
dadbcc4
64772e0
cd486de
1d3f007
0478509
e963124
164657c
023ba09
2d26373
9e3fe77
87558ce
e8ace06
aba8b9f
2eb07d0
049b205
e6d5bdb
7a66355
2539105
af6956c
82094b9
f45aced
d840eac
9dcbb36
aa25afd
1882055
6d935f0
5f1b12e
c7857ed
5f7b929
814802f
7266ac4
f9fecdd
105f31e
f733b80
245a5c3
ff9a764
823eb17
3000b13
739dd23
1d2a98b
a7e7498
964cb6f
9352fbb
84d9d65
3268c04
ea7306e
f5b053f
4a3fe0c
45d31b9
63f6e5d
b7bf003
77ffc6f
9039933
7de7230
19cc442
e2fe381
4d0e17a
9125eb8
6387527
d7ad064
28c238e
ea086a3
692e46a
e1a45a6
3d221a2
5416754
b9e482e
dba1f65
2342c1a
f520d94
5e6dd1a
5a35400
9fff3af
4c5e8b2
888426a
0164950
0e7d0d6
a5ace97
e5290e1
11316dd
4c3f18e
a2a273a
f41bc9e
705f791
1ddcc56
b05f73e
3153185
1627fa7
6134022
b57ea5e
edb3a5b
7d89447
aa2b1c6
dee0bb0
5d94f1c
9fd0d67
4bea022
2c94a82
32f3073
3baa745
c9414c7
0ff2e75
4d10391
d4031c6
1ba4da9
a6e06bc
834f2e6
ec2ef30
c8f9a5f
750f95f
f30869e
116b6fd
9316fa1
367d7bb
5cb9f84
28778fb
a45760d
ff301cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a heads up the duckdb icon isn't appear here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the icon name correct? or is it
duckdb-seeklogo
like in the guides?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
Thanks for checking this out. I saved the file under: duckdb-seeklogo.svg in the light and dark sections of vscode.
Kind Regards
Natalie
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon looks great in light mode but a little diff to view in dark mode as an fyi:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non blocker, maybe we should link to the template ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rest of these steps link to a diff quickstart, not sure if that's intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
Yep - this was intentional. The DuckDB one was to point users to the DuckDB setup page for general info on DuckDB and the GitHub one links users on the page in the DuckDB QS on how to create a repo (if they don't have one setup already.
I can remove these / change the links if you think it's best.
Kind Regards
Natalie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this link rigth? its not really a job link but a dbt run in the terminal link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be helpful to add somewhere here that once they do this, they should now have a models folder with staging and marts (i think?) where thy can perform transformations following the version control principles:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a heads up the cli repo says it archived but i can't find anything else so maybe it's ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two closing
</Tabs>
elements here. One of these will need to be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also i made the silly mistake of copying the whole thing, can we clarify that users shouldn't copy
workspaces/test (main)
or maybe remove that and just include teh command in the example to avoid confusion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this didn't seem to work for me, can we provide users with an example of what the command looks like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with
jafgen 6
and works (attached)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious if we want to add add'l steps to this quickstart guide, similar to the core install? e.g.: