Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs about ip rules #4159

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Fix docs about ip rules #4159

merged 3 commits into from
Sep 29, 2023

Conversation

ajaythomas
Copy link
Contributor

@ajaythomas ajaythomas commented Sep 29, 2023 •
edited
Loading

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

When we fix https://dbtlabs.atlassian.net/browse/ENTERPRISE-829, we can update the docs again.
But, today, we cannot add multiple ranges in a rule.

Preview

@vercel
Copy link

vercel bot commented Sep 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 5:53pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 29, 2023
@ajaythomas ajaythomas requested a review from nm0s September 29, 2023 15:09
@ajaythomas ajaythomas marked this pull request as ready for review September 29, 2023 15:10
@ajaythomas ajaythomas requested a review from a team as a code owner September 29, 2023 15:10
@ajaythomas ajaythomas force-pushed the enterprise-829-docs-no-multiple-ranges-in-a-rule branch from 3d0fd8d to db272c9 Compare September 29, 2023 16:21
@matthewshaver matthewshaver merged commit b14af54 into current Sep 29, 2023
7 checks passed
@matthewshaver matthewshaver deleted the enterprise-829-docs-no-multiple-ranges-in-a-rule branch September 29, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@nm0s nm0s nm0s approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaythomas @nm0s @matthewshaver