Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release note for removing old versions #4131

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Release note for removing old versions #4131

merged 4 commits into from
Sep 27, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding a release note about changed functionality in Cloud - older (prerelease) versions will be removed when (latest) is available.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

@matthewshaver matthewshaver requested a review from a team as a code owner September 26, 2023 19:58
@vercel
Copy link

vercel bot commented Sep 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 0:38am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Sep 26, 2023
nghi-ly
nghi-ly reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited about this change! A few style guide nits. Main feedback is regarding the prefixes for the YAML keys

website/docs/docs/dbt-versions/release-notes/04-Sept-2023/removing-prerelease-versions.md Outdated
---
title: "Removing old (prerelease) versions of dbt from dbt Cloud when (latest) is available"
description: "Improving the version selection options by removing prerelease versions whenever the latest version is available."
sidebar_label: "Removing old prerelease versions from dbt Cloud"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these three YAML keys all should include a prefix.

check out the process page https://www.notion.so/dbtlabs/Request-a-dbt-Cloud-release-note-f962f39b49af4a23811d70984fef4f65?pvs=4 and previous release notes for deets

website/docs/docs/dbt-versions/release-notes/04-Sept-2023/removing-prerelease-versions.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/04-Sept-2023/removing-prerelease-versions.md Outdated Show resolved Hide resolved
nghi-ly
nghi-ly approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewshaver matthewshaver merged commit d3cf4d1 into current Sep 27, 2023
@matthewshaver matthewshaver deleted the remove-version-releasenote branch September 27, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @nghi-ly