Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make column name to be fully qualified to prevent BQ confusion #864

Conversation

adrian3ka
Copy link

@adrian3ka adrian3ka commented Jan 23, 2024

resolves #173

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

For better support for an edge case in Bigquery, which gets confused by casting a column with the same name as its table name.

Checklist

  • This code is associated with an Issue that has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@adrian3ka
Copy link
Author

I am not so sure why the CI is failing and giving irrelevant error(s).

@dbeatty10 dbeatty10 added the bug Something isn't working label Apr 18, 2024
@dbeatty10 dbeatty10 added the nested Related to BQ's nested and repeated columns (STRUCT / RECORD) label Jun 4, 2024
Copy link

github-actions bot commented Dec 2, 2024

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 2, 2024
Copy link

github-actions bot commented Dec 9, 2024

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nested Related to BQ's nested and repeated columns (STRUCT / RECORD) Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

union should explicitly specify table name in casts
2 participants