Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.6.latest] persist view column comments #932

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2023

Backport 1672efd from #893.

* persist view column comments

* format: whitespace

* extracted get_matched_column macro

* move parenthesis to the calling macro

* changelog

* fix: remove matching column in different case

* fix: remove get_matched_column  macro - not much logic left there.

* escape column comments and add functional test

* Update Features-20230817-130731.yaml

* remove unneeded f string

* add test fixture to view test

* fix fixtures for TestPersistDocsDeltaView

* fix fixtures for TestPersistDocsDeltaView

* formatting

* fix tests

---------

Co-authored-by: Juri Krainjukov <[email protected]>
(cherry picked from commit 1672efd)
@github-actions github-actions bot requested a review from a team as a code owner November 3, 2023 22:45
@github-actions github-actions bot requested a review from VersusFacit November 3, 2023 22:45
@cla-bot cla-bot bot added the cla:yes label Nov 3, 2023
@mikealfare
Copy link
Contributor

spark-session is failing due to an issue in the test environment itself, not in dbt-spark

@mikealfare mikealfare merged commit 95a6f43 into 1.6.latest Nov 9, 2023
30 checks passed
@mikealfare mikealfare deleted the backport-893-to-1.6.latest branch November 9, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants