-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mcknight/fix test store test #832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht/fix-test-store-test
…ht/fix-test-store-test
…ht/fix-test-store-test
…bs/dbt-spark into mcknight/fix-test-store-test
colin-rogers-dbt
approved these changes
Oct 17, 2023
todo create backports as needed |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
* add teardown_method for store_test_fail test * create pr * add teardown to delta test class as it also builds tests on alt schema (cherry picked from commit 99c5c5a)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
* add teardown_method for store_test_fail test * create pr * add teardown to delta test class as it also builds tests on alt schema (cherry picked from commit 99c5c5a)
McKnight-42
added
the
backport 1.7.latest
Tag for PR to be backported to the 1.7.latest branch
label
Oct 17, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
* add teardown_method for store_test_fail test * create pr * add teardown to delta test class as it also builds tests on alt schema (cherry picked from commit 99c5c5a)
McKnight-42
added a commit
that referenced
this pull request
Oct 24, 2023
* add teardown_method for store_test_fail test * create pr * add teardown to delta test class as it also builds tests on alt schema (cherry picked from commit 99c5c5a) Co-authored-by: Matthew McKnight <[email protected]>
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Oct 24, 2023
* add teardown_method for store_test_fail test * create pr * add teardown to delta test class as it also builds tests on alt schema (cherry picked from commit 99c5c5a) Co-authored-by: Matthew McKnight <[email protected]>
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Oct 24, 2023
* add teardown_method for store_test_fail test * create pr * add teardown to delta test class as it also builds tests on alt schema (cherry picked from commit 99c5c5a) Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.7.latest
Tag for PR to be backported to the 1.7.latest branch
cla:yes
Skip Changelog
Skips GHA to check for changelog file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
test_store_test_failures
tests leave hanging artifacts due to change in schema name, need to add a teardown method to make sure we drop alt schema to stop build up of unnecessary schemas in ci/cd database overtime.Solution
Checklist