Use PyHive pure-sasl import #818

colin-rogers-dbt · 2023-06-28T17:25:00Z

resolves #524
resolves #864

Description

Checklist

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

github-actions · 2023-06-28T17:25:17Z

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

mikealfare · 2023-06-28T19:20:31Z

tests/unit/utils.py

@@ -75,7 +75,6 @@ def project_from_dict(project, profile, packages=None, selectors=None, cli_vars=
        project_root=project_root,
        project_dict=project,
        packages_dict=packages,
-        dependent_projects_dict={},


setup.py

dev-requirements.txt

setup.py

github-actions · 2023-11-09T00:34:45Z

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-818-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07383d906f5ab97e9f4db72926d401d45e47c2c2
# Push it to GitHub
git push --set-upstream origin backport-818-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-818-to-1.6.latest.

github-actions · 2023-11-09T00:34:47Z

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-818-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07383d906f5ab97e9f4db72926d401d45e47c2c2
# Push it to GitHub
git push --set-upstream origin backport-818-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-818-to-1.5.latest.

* Use PyHive pure-sasl import * Test PyHive pure-sasl import * update requirements.txt * use github fix for >3.11 * use github fix for >3.11 * fix pyhive spec * remove unnecessary requests extra * remove unnecessary sasl install * add changie * specify no-binary for pyodbc install * conditionally import sasl vs puresasl * conditionally import sasl vs pure-sasl * experiment with pure sasl SASLClient * file formatting * test using only puresasl * test using only puresasl * update requirements.txt * remove sasl from req * remove unused sys dependency * test spark-session * fix pure-sasl * allow pre-release installs * allow pre-release installs * use pyhive 0.7.0 * add pyhive back to reqs * fix setup.py and remove sasl from dev-requirements.txt * Update Dependencies-20230628-121341.yaml * remove unnecessary pip_pre arg from tox.ini --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 07383d9)

* Use PyHive pure-sasl import * Test PyHive pure-sasl import * update requirements.txt * use github fix for >3.11 * use github fix for >3.11 * fix pyhive spec * remove unnecessary requests extra * remove unnecessary sasl install * add changie * specify no-binary for pyodbc install * conditionally import sasl vs puresasl * conditionally import sasl vs pure-sasl * experiment with pure sasl SASLClient * file formatting * test using only puresasl * test using only puresasl * update requirements.txt * remove sasl from req * remove unused sys dependency * test spark-session * fix pure-sasl * allow pre-release installs * allow pre-release installs * use pyhive 0.7.0 * add pyhive back to reqs * fix setup.py and remove sasl from dev-requirements.txt * Update Dependencies-20230628-121341.yaml * remove unnecessary pip_pre arg from tox.ini --------- Co-authored-by: Mike Alfare <[email protected]> (cherry picked from commit 07383d9) Co-authored-by: colin-rogers-dbt <[email protected]>

Use PyHive pure-sasl import

d359a8f

colin-rogers-dbt requested a review from a team as a code owner June 28, 2023 17:25

colin-rogers-dbt requested a review from Fleid June 28, 2023 17:25

cla-bot bot added the cla:yes label Jun 28, 2023

colin-rogers-dbt added 8 commits June 28, 2023 10:36

Test PyHive pure-sasl import

bb3c688

update requirements.txt

44f1b14

use github fix for >3.11

7360353

use github fix for >3.11

3779c2d

fix pyhive spec

4982589

remove unnecessary requests extra

71030e3

remove unnecessary sasl install

ddd1f79

add changie

bcb47f5

mikealfare reviewed Jun 28, 2023

View reviewed changes

colin-rogers-dbt and others added 6 commits June 28, 2023 13:23

specify no-binary for pyodbc install

b5b2b20

conditionally import sasl vs puresasl

152a2ee

conditionally import sasl vs pure-sasl

0a51daa

Merge branch 'main' into usePureSasl

3c18e5b

experiment with pure sasl SASLClient

c80e599

file formatting

50a5a54

colin-rogers-dbt closed this Jun 29, 2023

colin-rogers-dbt reopened this Jun 29, 2023

colin-rogers-dbt requested a review from VersusFacit June 30, 2023 16:33

colin-rogers-dbt added 5 commits June 30, 2023 17:07

test using only puresasl

9e738b1

test using only puresasl

52a2ba7

update requirements.txt

a03e364

remove sasl from req

7987673

remove unused sys dependency

3941979

mikealfare reviewed Jul 5, 2023

View reviewed changes

setup.py Show resolved Hide resolved

mikealfare reviewed Jul 5, 2023

View reviewed changes

dev-requirements.txt Outdated Show resolved Hide resolved

colin-rogers-dbt added 2 commits August 3, 2023 12:58

Merge branch 'main' into usePureSasl

9ea4393

Merge branch 'main' into usePureSasl

3486590

mikealfare marked this pull request as draft August 3, 2023 23:04

This was referenced Aug 7, 2023

Bumping version to 1.3.3 and generate changelog #853

Merged

Bumping version to 1.4.3 and generate changelog #855

Merged

Bumping version to 1.5.2 and generate changelog #854

Merged

use pyhive 0.7.0

cede12f

colin-rogers-dbt marked this pull request as ready for review August 21, 2023 16:26

colin-rogers-dbt added 2 commits August 21, 2023 09:28

merge main

215b9fa

add pyhive back to reqs

c88567f

mikealfare reviewed Aug 21, 2023

View reviewed changes

setup.py Outdated Show resolved Hide resolved

mikealfare reviewed Aug 21, 2023

View reviewed changes

setup.py Outdated Show resolved Hide resolved

colin-rogers-dbt and others added 3 commits August 21, 2023 10:41

fix setup.py and remove sasl from dev-requirements.txt

2851b78

Update Dependencies-20230628-121341.yaml

9e0769e

remove unnecessary pip_pre arg from tox.ini

fc2c610

mikealfare approved these changes Aug 21, 2023

View reviewed changes

colin-rogers-dbt merged commit 07383d9 into main Aug 21, 2023

colin-rogers-dbt deleted the usePureSasl branch August 21, 2023 20:10

mikealfare mentioned this pull request Sep 27, 2023

ADAP-56: Python 3.11 Support #676

Closed

6 tasks

mikealfare added backport 1.5.latest labels Nov 9, 2023

This was referenced Nov 9, 2023

[Backport 1.6.latest] Use PyHive pure-sasl import #944

Merged

[Backport 1.5.latest] Use PyHive pure-sasl import #945

Merged

dbeatty10 mentioned this pull request Feb 21, 2024

[ADAP-789] [Feature] Upgrade PyHive to support Python 3.11 #864

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use PyHive pure-sasl import #818

Use PyHive pure-sasl import #818

colin-rogers-dbt commented Jun 28, 2023 •

edited by dbeatty10

Loading

github-actions bot commented Jun 28, 2023

mikealfare Jun 28, 2023

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 9, 2023

Use PyHive pure-sasl import #818

Use PyHive pure-sasl import #818

Conversation

colin-rogers-dbt commented Jun 28, 2023 • edited by dbeatty10 Loading

Description

Checklist

github-actions bot commented Jun 28, 2023

mikealfare Jun 28, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 9, 2023

colin-rogers-dbt commented Jun 28, 2023 •

edited by dbeatty10

Loading