Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not require alias to avoid duplicate aliasing with --empty #1162

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Do not require alias to avoid duplicate aliasing with --empty #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f4c0e
fix: Do not require alias to avoid duplicate aliasing during dry runs
anaghshineh Dec 14, 2024
a4aeaaf
chore: Forgot to add CHANGELOG entry
anaghshineh Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20241214-101933.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Stop adding aliases to render_limited output
time: 2024-12-14T10:19:33.470916-07:00
custom:
Author: anaghshineh
Issue: "1098"
1 change: 1 addition & 0 deletions dbt/adapters/spark/relation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class SparkRelation(BaseRelation):
is_iceberg: Optional[bool] = None
# TODO: make this a dict everywhere
information: Optional[str] = None
require_alias: bool = False

def __post_init__(self) -> None:
if self.database != self.schema and self.database:
Expand Down
6 changes: 5 additions & 1 deletion tests/functional/adapter/empty/test_empty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
from dbt.tests.adapter.empty.test_empty import BaseTestEmpty
from dbt.tests.adapter.empty.test_empty import BaseTestEmpty, BaseTestEmptyInlineSourceRef


class TestSparkEmpty(BaseTestEmpty):
pass


class TestSparkEmptyInlineSourceRef(BaseTestEmptyInlineSourceRef):
pass
Loading