Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to use pyhive function to get compatible sasl #1095

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ntnhaatj
Copy link

resolves #1094
docs dbt-labs/docs.getdbt.com/#

Problem

Current SASL factory for TSaslClientTransport using SASLClient from pure-sasl which is incompatible with pyhive

Solution

Pyhive provides a wrapper PureSASLClient which implement some missing methods to interact with thrift-sasl.

This MR update to use get_installed_sasl of pyhive to decide which sasl client should be use in current environment.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@ntnhaatj ntnhaatj requested a review from a team as a code owner August 31, 2024 09:42
Copy link

cla-bot bot commented Aug 31, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nhat.nguyent.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ntnhaatj ntnhaatj force-pushed the fix/pure-sasl-compatible branch from 9769fd2 to 6eb39bf Compare August 31, 2024 10:18
Copy link

cla-bot bot commented Aug 31, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @ntnhaatj

@ntnhaatj ntnhaatj force-pushed the fix/pure-sasl-compatible branch from 6eb39bf to 8b3380e Compare August 31, 2024 10:22
Copy link

cla-bot bot commented Aug 31, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @ntnhaatj

@nqvuong1998
Copy link

nqvuong1998 commented Sep 4, 2024

Hi @McKnight-42 , any update for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] AttributeError: 'SASLClient' object has no attribute 'start'
2 participants