Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/http odbc conn extra #1093

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Feature/http odbc conn extra #1093

merged 11 commits into from
Sep 12, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner August 30, 2024 00:04
@cla-bot cla-bot bot added the cla:yes label Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Aug 30, 2024
Closed
4 tasks
@colin-rogers-dbt
Copy link
Contributor Author

Successful run with new integration test type: https://github.com/dbt-labs/dbt-spark/actions/runs/10707550619

@colin-rogers-dbt colin-rogers-dbt self-assigned this Sep 5, 2024
mikealfare
mikealfare previously approved these changes Sep 10, 2024
View reviewed changes
@mikealfare mikealfare dismissed their stale review September 10, 2024 22:11

This PR was not ready for review

@mikealfare mikealfare marked this pull request as draft September 10, 2024 22:11
@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review September 11, 2024 18:13
mikealfare
mikealfare reviewed Sep 11, 2024
View reviewed changes
tests/unit/fixtures/profiles.py Outdated Show resolved Hide resolved
tests/unit/test_adapter.py Outdated Show resolved Hide resolved
tests/unit/test_adapter.py Show resolved Hide resolved
@colin-rogers-dbt colin-rogers-dbt merged commit 3fc624c into main Sep 12, 2024
20 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the feature/http_odbc_conn_extra branch September 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees

@colin-rogers-dbt colin-rogers-dbt

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @mikealfare @nilan3