Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standardize_grants_dict to handle potential case mismatches in grants table response #1087

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update standardize_grants_dict to handle potential case mismatches in grants table response #1087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1bae97
Update `standardize_grants_dict` to handle potential case mismatches …
lamalex Aug 3, 2024
b501e65
fix string interpolation syntax error
lamalex Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions dbt/adapters/spark/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,11 +496,24 @@ def python_submission_helpers(self) -> Dict[str, Type[PythonJobHelper]]:
}

def standardize_grants_dict(self, grants_table: "agate.Table") -> dict:
def get_cased_column_name_for_column(tuple_data: Tuple[str], column_name: str) -> str:
for item in tuple_data:
if item.lower() == column_name.lower():
return item
raise DbtRuntimeError(
f'Column "{column_name}" not found in grants table columns `{", ".join(grants_table.column_names)}`.'
)

column_names = grants_table.column_names
principal_column_name = get_cased_column_name_for_column(column_names, "Principal")
privilege_column_name = get_cased_column_name_for_column(column_names, "ActionType")
object_type_column_name = get_cased_column_name_for_column(column_names, "ObjectType")

grants_dict: Dict[str, List[str]] = {}
for row in grants_table:
grantee = row["Principal"]
privilege = row["ActionType"]
object_type = row["ObjectType"]
grantee = row[principal_column_name]
privilege = row[privilege_column_name]
object_type = row[object_type_column_name]

# we only want to consider grants on this object
# (view or table both appear as 'TABLE')
Expand Down
Loading