Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix secrets with DBT_ENV_SECRET_ for test env vars #1025

Closed
wants to merge 5 commits into from

Conversation

mikealfare
Copy link
Contributor

resolves dbt-labs/adapters-team-private#135

Problem

Environment variables containing secrets need to be prefixed with DBT_ENV_SECRET_ to be handled properly in dbt-core.

Solution

  • prefix testing environment variables with DBT_ENV_SECRET_
  • update the places where they get read in in /tests
  • update workflows that inject secrets

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 25, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@mikealfare
Copy link
Contributor Author

Running the integration tests against this branch manually: https://github.com/dbt-labs/dbt-spark/actions/runs/8840556857

@mikealfare
Copy link
Contributor Author

@mikealfare
Copy link
Contributor Author

@mikealfare mikealfare marked this pull request as draft April 29, 2024 15:41
@mikealfare
Copy link
Contributor Author

It looks like the host isn't being pulled in for the databricks test profiles.

@mikealfare mikealfare closed this Nov 9, 2024
@mikealfare mikealfare deleted the add-secrets-prefix-to-env-vars branch November 9, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant