Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pre-commit only #996

Merged
merged 6 commits into from
May 8, 2024
Merged

Move to pre-commit only #996

merged 6 commits into from
May 8, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 26, 2024

Problem

Our linters and typechecking tools create a lot of dependabot PRs. This is aggravated by the fact that we keep one set of reqs in dev-requirements.txt and another in .pre-commit-config.yaml.

Solution

  • move all reqs and config for linters and typecheckers into .pre-commit-config.yaml
  • run pre-commit autoupdate
  • run pre-commit run --all-files
  • fix resulting error from running pre-commit
  • remove make recipes that are no longer relative or are duplicative

Out of scope:

  • as a follow up, create a weekly action that runs pre-commit autoupdate against a temp branch, runs linting and typechecking, and merges on success or creates a PR on failure

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Apr 26, 2024
@mikealfare mikealfare self-assigned this Apr 26, 2024
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 26, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare requested a review from a team April 26, 2024 02:52
@mikealfare mikealfare merged commit 5b92881 into main May 8, 2024
18 checks passed
@mikealfare mikealfare deleted the move-to-pre-commit-only branch May 8, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants