Finish internal build workflow #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
VersusFacit
commented
Mar 21, 2024
|
|
||
| uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main | ||
| uses: "dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@mp/finish_internal_workflow" |
There was a problem hiding this comment.
Going to change this once main has all the changes needed to support all the other workflows. Since this PR's workflow can be invoked using the branch reference, I'll merge at the time I can revert to main (unless there is an alternate path desired)
VersusFacit
commented
Mar 21, 2024
setup.py
Outdated
| @@ -33,8 +33,9 @@ def _get_plugin_version_dict(): | |||
| _version_path = os.path.join(this_directory, "dbt", "adapters", "snowflake", "__version__.py") | |||
| _semver = r"""(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)""" | |||
| _pre = r"""((?P<prekind>a|b|rc)(?P<pre>\d+))?""" | |||
| _build = r"""(\+build[0-9]+)?""" | |||
There was a problem hiding this comment.
The ? renders it optional which is what I think we want -- there will be many builds without this suffix.
VersusFacit
force-pushed
the
add_release_internal_workflow
branch
from
e7fd38f to
fe6bffa
Compare
emmyoop
approved these changes
Mar 26, 2024
mikealfare
reviewed
Mar 26, 2024
|
Finished build for last sha! https://github.com/dbt-labs/dbt-snowflake/actions/runs/8443836576 |
|
sha concern will be followed up in next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need a workflow that calls the internal build release workflow found here.
Solution
This PR adds the file and documents the what/how/why.
Proof of the build process working:
Checklist