Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/decouple adapters from core #865

Merged
merged 63 commits into from
Jan 17, 2024
Merged

Feature/decouple adapters from core #865

merged 63 commits into from
Jan 17, 2024

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Dec 14, 2023 •
edited
Loading

resolves #882, dbt-labs/dbt-core#9187
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42
update RELEASE_BRANCH env
032b5b5
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
16470c2
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
4c475f1
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
81d5d5d
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
f1d8078
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
2773177
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
77a2b66
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
d9d3d2d
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
a51efc2
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
df68367
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
d9ab1ac
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
942473f
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
f579bf9
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
eb89108
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
2213e2c
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
a97950b
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
f5d4ebf
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
701a9ce
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
b462076
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
f57b14c
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
06083ab
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
508e7b2
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
26b035c
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
2f311e2
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
fca0498
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
cbb1ed2
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
57f4bee
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
1afef32
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
62338a1
@McKnight-42
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
68a923f
@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Dec 14, 2023
@McKnight-42 McKnight-42 self-assigned this Dec 14, 2023
@cla-bot cla-bot bot added the cla:yes label Dec 14, 2023
mikealfare
mikealfare reviewed Jan 5, 2024
View reviewed changes
dbt/adapters/snowflake/relation_configs/dynamic_table.py

import agate
from dbt.adapters.relation_configs import RelationConfigChange, RelationResults
from dbt.contracts.graph.nodes import ModelNode
from dbt.contracts.relation import ComponentName
from dbt.adapters.contracts.relation import RelationConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine these

dbt/include/snowflake/macros/adapters.sql Show resolved Hide resolved
@McKnight-42 McKnight-42 marked this pull request as ready for review January 9, 2024 22:51
@McKnight-42 McKnight-42 requested a review from a team as a code owner January 9, 2024 22:51
@McKnight-42 McKnight-42 removed the Skip Changelog Skips GHA to check for changelog file label Jan 9, 2024
@McKnight-42 McKnight-42 requested a review from mikealfare January 9, 2024 22:57
@McKnight-42 McKnight-42 mentioned this pull request Jan 16, 2024
Closed
2 tasks
@McKnight-42 McKnight-42 merged commit a43f86b into main Jan 17, 2024
15 checks passed
@McKnight-42 McKnight-42 deleted the feature/decouple-adapters-from-core branch January 17, 2024 17:05
@ksingh225
Copy link

ksingh225 commented Aug 22, 2024 •
edited
Loading

I am still facing this issue , ModuleNotFoundError: No module named 'dbt.clients.agate_helper'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@mikealfare mikealfare mikealfare approved these changes

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-1092] [Feature] Migrate base adapter references to match dbt-core
4 participants
@McKnight-42 @ksingh225 @mikealfare @colin-rogers-dbt