Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-971: Fix issue where dynamic tables were returning null for type #818

Merged
merged 8 commits into from
Oct 31, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Oct 31, 2023

resolves #817, dbt-labs/dbt-core#8864

Problem

Dynamic tables were returning null for type in catalog queries.

Solution

  • add test demonstrating issue
  • fix catalog query

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 31, 2023
@mikealfare mikealfare requested a review from a team as a code owner October 31, 2023 01:55
@mikealfare mikealfare requested a review from Fleid October 31, 2023 01:55
@cla-bot cla-bot bot added the cla:yes label Oct 31, 2023
@mikealfare mikealfare added backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Oct 31, 2023
@mikealfare mikealfare merged commit 1f123b7 into main Oct 31, 2023
13 checks passed
@mikealfare mikealfare deleted the dynamic-tables/bug/adap-971 branch October 31, 2023 04:14
@mikealfare mikealfare added backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch and removed backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Oct 31, 2023
@github-actions
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-818-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f123b746080b1c02c3b34713246db9f69892922
# Push it to GitHub
git push --set-upstream origin backport-818-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-818-to-1.6.latest.

github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
…#818)

* changelog
* create test demonstrating the issue
* map nulls to dynamic table

(cherry picked from commit 1f123b7)
@github-actions
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-818-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f123b746080b1c02c3b34713246db9f69892922
# Push it to GitHub
git push --set-upstream origin backport-818-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-818-to-1.6.latest.

mikealfare added a commit that referenced this pull request Oct 31, 2023
…#818)

* changelog
* create test demonstrating the issue
* map nulls to dynamic table

(cherry picked from commit 1f123b7)
mikealfare added a commit that referenced this pull request Oct 31, 2023
…#818) (#820)

* changelog
* create test demonstrating the issue
* map nulls to dynamic table

(cherry picked from commit 1f123b7)
mikealfare added a commit that referenced this pull request Nov 1, 2023
…#818) (#819)

* changelog
* create test demonstrating the issue
* map nulls to dynamic table

(cherry picked from commit 1f123b7)

Co-authored-by: Mike Alfare <[email protected]>
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
…dbt-labs#818) (dbt-labs#819)

* changelog
* create test demonstrating the issue
* map nulls to dynamic table

(cherry picked from commit 1f123b7)

Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes
Projects
None yet
2 participants