Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Iceberg table format in Dynamic Tables #1183

Merged
merged 36 commits into from
Sep 27, 2024
Merged

Add support for Iceberg table format in Dynamic Tables #1183

merged 36 commits into from
Sep 27, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Sep 17, 2024 •
edited
Loading

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

dbt-snowflake does not currently support Iceberg table format when using dynamic tables.

Solution

  • catch the user configuration required for Iceberg support
  • update dynamic table relation templates to include the new config
  • put this new config behind the Iceberg behavior flag to make this feature opt-in

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Sep 17, 2024
@cla-bot cla-bot bot added the cla:yes label Sep 17, 2024
@mikealfare mikealfare changed the base branch from main to dynamic-tables/testing-improvements September 20, 2024 17:10
@mikealfare mikealfare changed the base branch from dynamic-tables/testing-improvements to main September 20, 2024 17:10
@mikealfare mikealfare changed the base branch from main to dynamic-tables/testing-improvements September 20, 2024 20:04
@mikealfare mikealfare changed the base branch from dynamic-tables/testing-improvements to main September 20, 2024 20:04
@mikealfare
Merge branch 'main' into dynamic-tables/iceberg-format
04ec380 
# Conflicts:
#	tests/functional/relation_tests/dynamic_table_tests/models.py
#	tests/functional/relation_tests/dynamic_table_tests/test_basic.py
#	tests/functional/relation_tests/models.py
#	tests/functional/relation_tests/test_relation_type_change.py
@mikealfare
undo formatting changes to make function changes easier to see
4373bdd
@mikealfare
add iceberg dynamic tables to existing dynamic table tests
951a2ab
@mikealfare mikealfare marked this pull request as ready for review September 20, 2024 23:30
@mikealfare mikealfare requested a review from a team as a code owner September 20, 2024 23:30
@mikealfare mikealfare enabled auto-merge (squash) September 26, 2024 22:14
@mikealfare mikealfare disabled auto-merge September 27, 2024 02:19
@mikealfare mikealfare merged commit 0521395 into main Sep 27, 2024
19 checks passed
@mikealfare mikealfare deleted the dynamic-tables/iceberg-format branch September 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@VersusFacit VersusFacit VersusFacit left review comments

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikealfare @VersusFacit @colin-rogers-dbt