-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Iceberg Table Materialization #1170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
VersusFacit
commented
Aug 22, 2024
…ugh to relation object
VersusFacit
commented
Aug 26, 2024
VersusFacit
force-pushed
the
mp/add_iceberg_tables
branch
2 times, most recently
from
August 29, 2024 06:51
c959b7b
to
7da28be
Compare
transient manually.
VersusFacit
force-pushed
the
mp/add_iceberg_tables
branch
from
August 29, 2024 07:10
7da28be
to
1887208
Compare
VersusFacit
commented
Aug 29, 2024
tests/functional/adapter/list_relations_tests/test_show_objects.py
Outdated
Show resolved
Hide resolved
VersusFacit
force-pushed
the
mp/add_iceberg_tables
branch
from
August 29, 2024 07:32
32ad646
to
8150261
Compare
3 tasks
VersusFacit
commented
Sep 11, 2024
VersusFacit
force-pushed
the
mp/add_iceberg_tables
branch
from
September 11, 2024 07:20
f2e40fb
to
493c6ae
Compare
VersusFacit
changed the title
Iceberg support prototyping
Add support for Iceberg Table Materialization
Sep 11, 2024
mikealfare
reviewed
Sep 11, 2024
tests/functional/adapter/list_relations_tests/test_show_objects.py
Outdated
Show resolved
Hide resolved
Blocked by behavior flag / Jinja security issue. Once we have a solution forward, this PR is ready for code review round 2! |
colin-rogers-dbt
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #321
Add support for Iceberg Table Materialization
Built atop jaffle shop classic for testing.
Problem
We want to add support for materialization S3 bucket Iceberg tables in Snowflake.
Example of our decided model config interface:
Solution
table
materializationis_iceberg
as a field toshow objects
(this will be given to us by Snowflake for free one day)is_iceberg
to determinedrop_relation_if_exists
calls before building a table (table -> Iceberg, Iceberg -> table)Caveats
this is ready for review but needs two more things I can identify:
Impact
Get this shipped for Cloud folks to start using!!
Manually testing scenarios
create
s from table to iceberg table and backleft join
withshow objects
was worth itChecklist
(well, err, sort of)edit: Now, this PR includes tests, or tests are not required/relevant for this PR