Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to list of supported Python versions #1144

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Jul 22, 2024

resolves #903

Problem

Adding Python 3.12 should pass a series of tests

  • pytest tests/unit local
  • pytest tests/functional local
  • dbt seed && dbt run in a localjaffle shop using plain pip install dbt-snowflake with 3.12 active
  • smoke testing run using test-bundle on snowflake against the jaffle-shop-base scenario with 3.12.3 active
  • GHA workflow involving integration tests
  • release workflow still works

Solution

No code changes beyond GHA workflows and setup.py are needed for this adapter.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Jul 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Jul 22, 2024
@VersusFacit
Copy link
Contributor Author

VersusFacit commented Jul 22, 2024

Verified working release job for 3.12 enabled 🎉

https://github.com/dbt-labs/dbt-snowflake/actions/runs/10046736112/job/27766937211

You can also see 3.12 integration tests working on this very PR.

https://github.com/dbt-labs/dbt-snowflake/actions/runs/10046882814/job/27767327557?pr=1144

@VersusFacit VersusFacit marked this pull request as ready for review July 22, 2024 19:55
@VersusFacit VersusFacit requested a review from a team as a code owner July 22, 2024 19:55
@VersusFacit VersusFacit changed the title Adding 12 for migration testing Add Python 3.12 to list of supported version Jul 22, 2024
@VersusFacit VersusFacit self-assigned this Jul 22, 2024
@mikealfare
Copy link
Contributor

We also need to update these lines:

const supportedPythonVersions = ["3.8", "3.9", "3.10", "3.11"];

envlist = py38,py39,py310,py311

[testenv:{unit,py38,py39,py310,py311,py}]

[testenv:{integration,py38,py39,py310,py311,py}-{snowflake}]

args:
- --line-length=99
- --target-version=py38
- --target-version=py39
- --target-version=py310
- --target-version=py311
additional_dependencies: [flaky]

@VersusFacit VersusFacit merged commit 29467c3 into main Jul 23, 2024
19 checks passed
@VersusFacit VersusFacit deleted the ADAP-903/add_support_for_3.12 branch July 23, 2024 17:42
@VersusFacit VersusFacit changed the title Add Python 3.12 to list of supported version Add Python 3.12 to list of supported Python versions Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Spike on supporting Py3.12 in dbt-snowflake
3 participants