Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro for warehouse selection #114

Closed

Conversation

javiCalvo
Copy link
Contributor

resolves #103 Macro for warehouse selection

Description

The change is minimal to call a macro that gets the actual / default warehouse for the model and returns the same but can be overriden for more complex logics (ie. select a different warehouse depending on the environment). Test are missing as I don't know how to start with them but the change is working.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

@cla-bot
Copy link

cla-bot bot commented Mar 21, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Javier Calvo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Mar 21, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Javier Calvo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@javiCalvo javiCalvo force-pushed the feature/custom-warehouse-macro branch from d934788 to b9242a0 Compare March 21, 2022 15:12
@cla-bot
Copy link

cla-bot bot commented Mar 21, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Javier Calvo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@javiCalvo javiCalvo closed this Mar 21, 2022
@javiCalvo javiCalvo deleted the feature/custom-warehouse-macro branch March 21, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-333] Macro for warehouse selection
1 participant