test_python_model.py::TestSecrets::test_secrets is failing in some scenarios
#1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
|
ci run on this branch to track multiple runs see if test fails: https://github.com/dbt-labs/dbt-snowflake/actions/runs/9715531000 |
mikealfare
reviewed
Jun 27, 2024
| ) | ||
| project.run_sql( | ||
| "create or replace external access integration test_external_access_integration allowed_network_rules = (test_network_rule) allowed_authentication_secrets = (test_secret) enabled = true;" | ||
| f"create or replace external access integration {test_external_access_integration} allowed_network_rules = ({test_network_rule}) allowed_authentication_secrets = (test_secret) enabled = true;" |
There was a problem hiding this comment.
It looks like we missed an instance of test_secret.
… to the python model fixture
colin-rogers-dbt
approved these changes
Jun 28, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-1096-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 220f08724a5b8d4d2e3bd461b15af3346f168c88
# Push it to GitHub
git push --set-upstream origin backport-1096-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latestThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1003
docs dbt-labs/docs.getdbt.com/#
Problem
in ci/cd test is failing for
This appears to be caused by our ci/cd running multiple instances of tests across various versions of python and os types.
Solution
adding a
uuidsuffix to the end of each required variable for the secrets should stop collision between version running at same test as each instance should have its ownuuidChecklist